[PATCH] D136512: [AA] Allow for flow-sensitive analyses.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

This looks fine, just some style nits.



================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:554
   AliasResult alias(const MemoryLocation &LocA, const MemoryLocation &LocB,
-                    AAQueryInfo &AAQI);
+                    AAQueryInfo &AAQI, const Instruction *I = nullptr);
+
----------------
We'd usually call this `CxtI` (the "context instruction").


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:686
+                            const MemoryLocation &LocB, AAQueryInfo &AAQI,
+                            const Instruction *I = nullptr) = 0;
 
----------------
You probably don't need `= nullptr` here and basically anywhere that is not public API.


================
Comment at: llvm/include/llvm/Analysis/CFLSteensAliasAnalysis.h:70
   AliasResult alias(const MemoryLocation &LocA, const MemoryLocation &LocB,
-                    AAQueryInfo &AAQI) {
+                    AAQueryInfo &AAQI, const Instruction * /* I */) {
     if (LocA.Ptr == LocB.Ptr)
----------------
I don't think such comments are typical in LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136512/new/

https://reviews.llvm.org/D136512