[PATCH] D139350: [AVR] Register AVRDAGToDAGISel pass with the pass manager

Ievgenii Meshcheriakov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 03:10:39 PST 2022


eugmes planned changes to this revision.
eugmes added a comment.

A `static char ID` needs to be added to `AVRDAGToDAGISel`, and probably to `AMDGPUDAGToDAGISel`.



================
Comment at: llvm/lib/Target/AVR/AVRISelDAGToDAG.cpp:588
+
+INITIALIZE_PASS(AVRDAGToDAGISel, "avr-isel",
+                "AVR DAG->DAG Instruction Selection", false, false)
----------------
I think this requires a new instance of ID for the class to be registered. And somebody else is also missing it and uses one from SelectionDAGISel (AMDGPUDAGToDAGISel is one of such classes). That's why there is a double registration error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139350/new/

https://reviews.llvm.org/D139350



More information about the llvm-commits mailing list