[PATCH] D139315: [NFC][LLVM-MT] Fix buffer-overflow when comparing buffers

Juan Manuel Martinez CaamaƱo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 01:48:57 PST 2022


jmmartinez added inline comments.


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:153-157
+      bool SameSize =
+          OutputBuffer->getBufferSize() == FileBuffer->getBufferSize();
+      Same = SameSize && std::equal(OutputBuffer->getBufferStart(),
+                                    OutputBuffer->getBufferEnd(),
+                                    FileBuffer->getBufferStart());
----------------
abrachet wrote:
> That should work too. WDYT?
I didn't know about that overload. I'll change it use your version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139315/new/

https://reviews.llvm.org/D139315



More information about the llvm-commits mailing list