[llvm] 500587e - [LLVM][Release] Prevent empty runtime name in release script

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2022-12-06T09:36:50Z
New Revision: 500587e23dfd33dcd0169a5ab9e2657a6b12c315

URL: https://github.com/llvm/llvm-project/commit/500587e23dfd33dcd0169a5ab9e2657a6b12c315
DIFF: https://github.com/llvm/llvm-project/commit/500587e23dfd33dcd0169a5ab9e2657a6b12c315.diff

LOG: [LLVM][Release] Prevent empty runtime name in release script

Unlike projects, runtimes doesn't have a default set of names.
This means you get a leading space at the start, which gets converted
to a ';' giving ";<runtime name>;<runtime name>".

CMake then errors because the "" before the first ';' is treated
as a runtime name and of course it's not a valid name.

Fix this by removing the leading spaces from runtimes before we
insert the ';'.

Reviewed By: ldionne

Differential Revision: https://reviews.llvm.org/D139306

Added: 
    

Modified: 
    llvm/utils/release/test-release.sh

Removed: 
    


################################################################################
diff  --git a/llvm/utils/release/test-release.sh b/llvm/utils/release/test-release.sh
index cb01ed5bd8843..0c214261c2723 100755
--- a/llvm/utils/release/test-release.sh
+++ b/llvm/utils/release/test-release.sh
@@ -405,6 +405,10 @@ function configure_llvmCore() {
     esac
 
     project_list=${projects// /;}
+    # Leading spaces will result in ";<runtime name>". This causes a CMake
+    # error because the empty string before the first ';' is treated as an
+    # unknown runtime name.
+    runtimes=$(echo $runtimes | sed -e 's/^\s*//')
     runtime_list=${runtimes// /;}
     echo "# Using C compiler: $c_compiler"
     echo "# Using C++ compiler: $cxx_compiler"