[PATCH] D137368: [lld-macho] Overhaul map file code

Tue Dec 6 01:11:14 PST 2022

DavidSpickett added a comment.

> This buildbot doesn't even seem to send out emails for failing builds, so I'm not sure how I'm supposed to have noticed that it was failing.

This is because once a buildbot is red it doesn't send new emails, because the chance of it being the same failure over and over is pretty high. That's why we keep an eye on exactly what is making it red.

So you weren't supposed to notice, that's why we follow up like this :)

> Anyway, I'm skeptical that the problem stems from code changes in this diff and not some bug in the 2-stage bootstrap. Re-landing to see if it still repros.

It does - https://lab.llvm.org/buildbot/#/builders/178/builds/3460

It also fails in stage 1 so either we have a bug in the released clang or more likely there's some 32/64 bit type confusion going on. I have seen this before in lld.

I will repro this when I get a chance. You may very well be correct that this change didn't add the issue, it just made it visible.

> Well, looks like the test is still broken. Is there a way to disable it just on that one specific buildbot?

Unfortunately not by bot, but disabling the test on arm 32 bit isn't a big deal. Realistically, this is one of the few reliable 32 bit arm bots in any case. I will do that change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137368/new/

https://reviews.llvm.org/D137368