[PATCH] D137620: [BOLT] Don't align .text to pageAlign

Tue Dec 6 00:57:47 PST 2022

maksfb added a comment.

> Aligning to regular page align seems reasonable in case of use-old-text(if we accept that for most mid-sized binaries it's not possible), even though i'm not sure it significantly affects performance without huge pages,

I don't have any performance data for regular-size pages. It will be good to collect some, e.g. for clang. If there's indeed no difference, we can do page-size alignment only for huge pages.

> but if we create new segment, 64 bytes seems fine, isn't it?

Is it b/c we assume there's nothing but a PHDR table before the code in the new segment?

> But we care more about alignment value than padding size.

Should we always align and disregarding the padding then (i.e. keep things as they are)? Sorry, if I missed your point.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137620/new/

https://reviews.llvm.org/D137620