[PATCH] D137483: [NFC][PowerPC] Add NFC fixes to PPCInstrinfo.cpp when getting the defined machine instruction.
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 5 18:19:26 PST 2022
amyk updated this revision to Diff 480306.
amyk added a comment.
Apply @shchenz's suggestion to this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137483/new/
https://reviews.llvm.org/D137483
Files:
llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
Index: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
+++ llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
@@ -3380,11 +3380,13 @@
continue;
Register TrueReg = TRI->lookThruCopyLike(Reg, MRI);
if (Register::isVirtualRegister(TrueReg)) {
- DefMI = MRI->getVRegDef(TrueReg);
- if (DefMI->getOpcode() == PPC::LI || DefMI->getOpcode() == PPC::LI8 ||
- DefMI->getOpcode() == PPC::ADDI ||
- DefMI->getOpcode() == PPC::ADDI8) {
+ MachineInstr *DefMIForTrueReg = MRI->getVRegDef(TrueReg);
+ if (DefMIForTrueReg->getOpcode() == PPC::LI ||
+ DefMIForTrueReg->getOpcode() == PPC::LI8 ||
+ DefMIForTrueReg->getOpcode() == PPC::ADDI ||
+ DefMIForTrueReg->getOpcode() == PPC::ADDI8) {
OpNoForForwarding = i;
+ DefMI = DefMIForTrueReg;
// The ADDI and LI operand maybe exist in one instruction at same
// time. we prefer to fold LI operand as LI only has one Imm operand
// and is more possible to be converted. So if current DefMI is
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137483.480306.patch
Type: text/x-patch
Size: 1178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/9f9a7b28/attachment.bin>
More information about the llvm-commits
mailing list