[PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 17:56:51 PST 2022


dblaikie added a comment.

Perhaps the change to use accessors could be removed, now that you've used it to find all the places that needed to be fixed up? (like just using it for cleanup/temporary purposes, without needing to commit that API change?)



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:115
+    private:
+      uint64_t Fields[2];
+
----------------
How come this became an array? Rather than keeping it as two named fields?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139379/new/

https://reviews.llvm.org/D139379



More information about the llvm-commits mailing list