[PATCH] D139298: WIP: Add error handling to demangle API

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/Demangle/Demangle.cpp:75-78
+  if (!isItaniumEncoding(M)) {
+    E = llvm::make_error_code(DemangleError::InvalidFormat);
+    return {};
+  }
----------------
Part of what I was hoping for was that we wouldn't need an explicit `isItaniumEncoding` check, even inside the implementation - that `Demangler::parse` could produce that as a separate error result if it parsed something without the desired prefix. Would that be possible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139298/new/

https://reviews.llvm.org/D139298