[PATCH] D132646: [LLVM][TableGen] Support combined cells in jupyter kernel

Mon Dec 5 15:33:55 PST 2022

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Mostly looks good, not sure about collapsing magic at top, but beyond that.

================
Comment at: llvm/utils/TableGen/jupyter/tablegen_kernel/kernel.py:86
+        Returns a tuple of newline joined code lines and a dictionary of magic.
+        Where the key is the magic name (minus the %) and the values are lists
+        of the arguments to the magic.
----------------
Wouldn't this collapse all magic to top rather than allowing different magic per section?  And in the examples, it seems we have magic at the top only per sections of code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132646/new/

https://reviews.llvm.org/D132646