[PATCH] D139370: [mlgo] Dependency-free training mode logger

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/TrainingLogger.cpp:112
+//
+// Example:
+// {"features":[list of TensorSpecs], "score":<a tensor spec>}
----------------
jacobhegna wrote:
> where in the header is the length of the tensor buffer stored? (to deal with newline bytes in the tensor buffer), in the value of the features key?
we have the shape and the type of the scalar value in the buffer, so we get the size from there. See for example how we write (L 168 this file) and then how we read (line 63 in log_reader.py)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139370/new/

https://reviews.llvm.org/D139370