[PATCH] D137599: [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 14:06:12 PST 2022


MaskRay added a comment.

I created D139368 <https://reviews.llvm.org/D139368> to simplify the repetitions with `.irp`.



================
Comment at: libunwind/src/assembly.h:194
+// against a version that does not provide the HWCAP2.
+#define GLIBC_VERSION_SYM .quad __parse_hwcap_and_convert_at_platform
+#else
----------------
This doesn't work as intended.

`.quad __parse_hwcap_and_convert_at_platform` without a definition creates an undefined symbol.
There it is un-referenced there won't be a `undefined symbol/reference` error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137599/new/

https://reviews.llvm.org/D137599



More information about the llvm-commits mailing list