[PATCH] D137788: [sanitizers] [windows] Correctly override functions with backward jmps

Mon Dec 5 13:55:55 PST 2022

gregstoll added a comment.

In D137788#3972062 <https://reviews.llvm.org/D137788#3972062>, @zero9178 wrote:

> In D137788#3972045 <https://reviews.llvm.org/D137788#3972045>, @mstorsjo wrote:
>
>> In D137788#3971968 <https://reviews.llvm.org/D137788#3971968>, @zero9178 wrote:
>>
>>> FWIW, after updating to Windows 11 today I started experiencing the same crashes with ASAN builds, remembered this patch and applied it to my local clang build. Works without issues now with the patch applied.
>>
>> Thanks for the data point! Are you able to look into running and fixing the tests so that they cover this issue (so that they fail before applying the functional change and succeed afterwards)?
>
> Sure, I'll try to find some time for it soon.
> @gregstoll would you mind if I commandeer the revision if I can fix the tests?

Nope, go for it! I was hoping to get back to it sometime but that probably won't happen until the new year, and I'd really just rather have it fixed 🙂

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137788/new/

https://reviews.llvm.org/D137788