[PATCH] D138238: [SROA] For non-speculatable `load`s of `select`s -- split block, insert then/else blocks, form two-entry PHI node

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/SROA.h:140
+  /// From this:
+  ///   %P2 = select i1 %cond, i32* %Alloca, i32* %Other
+  ///   %V = load i32* %P2
----------------
Use opaque pointer example?


================
Comment at: llvm/lib/Passes/PassRegistry.def:481
+                          parseSROAOptions,
+                          "PreserveCFG;ModifyCFG")
 FUNCTION_PASS_WITH_PARAMS("print<stack-lifetime>",
----------------
outdated option names?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138238/new/

https://reviews.llvm.org/D138238