[PATCH] D138082: GlobalISel: ComputeNumSignBits from load range metadata

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:709-710
     // e.g. i16->i32 = '17' bits known.
     const MachineMemOperand *MMO = *MI.memoperands_begin();
     return TyBits - MMO->getSizeInBits() + 1;
   }
----------------
This can now be `return TyBits - Ld->getMemSizeInBits() + 1;`


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:724-725
     // e.g. i16->i32 = '16' bits known.
     const MachineMemOperand *MMO = *MI.memoperands_begin();
     return TyBits - MMO->getSizeInBits();
   }
----------------
ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138082/new/

https://reviews.llvm.org/D138082