[PATCH] D139335: [BOLT] Fix blocks layout reverse iterators

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 10:05:50 PST 2022


yota9 added a comment.

@Amir Currently these iterators are almost unused - I see them used only under opts::ReportBadLayout right now. After I've tried to use them by my self I've found out that there are some problems with them, e.g. BBs hasInstructions() assert appeared. Anyway it does not look like it is right to use end() block iterator as an reverse begin...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139335/new/

https://reviews.llvm.org/D139335



More information about the llvm-commits mailing list