[PATCH] D139133: [SPIR-V] Support memory(...) function attributes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 09:07:25 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:60
+
+  if (F.hasFnAttribute(Attribute::AttrKind::ReadNone) ||
+      MemEffects.doesNotAccessMemory())
----------------
ReadNone still exists? I thought it was removed. Why check it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139133/new/

https://reviews.llvm.org/D139133



More information about the llvm-commits mailing list