[PATCH] D138646: [AAPointerInfo] track multiple constant offsets for each use

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Can we have a test for phi and store-load propagation to verify it's working as expected (not only selects)?



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1395-1398
+    if (!PotentialConstantsAA.isAtFixpoint()) {
+      Follow = false;
+      return;
+    }
----------------
This doesn't make sense to me. We need to look at all VariableOffsets and decide. So `return` should only be present if we give up.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1405
+    }
+    NewOI = UnionOfAllCopies;
+  }
----------------
I don;t follow why we need two extra OffsetInfo objects here. We modify NewOI anyway, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138646/new/

https://reviews.llvm.org/D138646