[PATCH] D139253: [InstCombine] fold more icmp + select patterns by distributive laws

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

It would be easier to review if you pre-commit the tests. You can add `; negative test` comments in this patch to make it clear when a test is not intended to change.
Why are there changes in test files that do contain the patterns that are matched in this patch?



================
Comment at: llvm/test/Transforms/InstCombine/select-cmp.ll:212
+; CHECK-NEXT:    [[R_V:%.*]] = select i1 [[C:%.*]], i6 [[Y:%.*]], i6 [[Z:%.*]]
+; CHECK-NEXT:    [[R:%.*]] = icmp uge i6 [[R_V]], [[X:%.*]]
+; CHECK-NEXT:    ret i1 [[R]]
----------------
This is not correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139253/new/

https://reviews.llvm.org/D139253