[PATCH] D138789: [LLParser] Support symbolic address space numbers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Seems mildly convenient for some lit tests



================
Comment at: llvm/test/Assembler/symbolic-addrspace.ll:23
+  %alloca = alloca i32, addrspace("A")
+  ret void
+}
----------------
Can you also test some cases where the string doesn't match the expected address space (e.g. alloca("G"))


================
Comment at: llvm/test/Assembler/symbolic-addrspace.ll:51
+ at str = private addrspace(@A) constant [4 x i8] c"str\00"
+; ERR-AT-SYMBOL: [[#@LINE-1]]:26: error: expected integer or string constant
----------------
Can you also test the error if it's a number in a string, e.g. "0"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138789/new/

https://reviews.llvm.org/D138789