[PATCH] D138813: [AArch64] implement GPR (U/S)(MIN/MAX) instruction SDag support

[Ties Stuij via Phabricator via llvm-commits]

stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/min-max.ll:2-4
 ; RUN: llc -mtriple=aarch64-eabi %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-ISEL
+; RUN: llc -mtriple=aarch64-eabi %s -o - -mattr=+cssc | FileCheck %s --check-prefixes=CHECK,CHECK-ISEL-CSSC
 ; RUN: llc -mtriple=aarch64-eabi -global-isel %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-GLOBAL
----------------
lenary wrote:
> You might get better test check merging with this instead, which would show the cases where CSSC matters and where it doesn't better.
> 
> Most of the reason that GlobalISel isn't merging is because it emits the max/min in the opposite order sometimes :(.
I'll look into this when the gisel patch for this lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138813/new/

https://reviews.llvm.org/D138813