[llvm] 04aae25 - [LLVM][Runtimes] Surround unknown runtime with ""

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2022-12-05T11:33:29Z
New Revision: 04aae2527bb1abea554ff8051a95cda9b1fea23c

URL: https://github.com/llvm/llvm-project/commit/04aae2527bb1abea554ff8051a95cda9b1fea23c
DIFF: https://github.com/llvm/llvm-project/commit/04aae2527bb1abea554ff8051a95cda9b1fea23c.diff

LOG: [LLVM][Runtimes] Surround unknown runtime with ""

So that when you do something like:
-DLLVM_ENABLE_RUNTIMES=;compiler-rt;libcxx;libcxxabi;libunwind

You get:
Runtime "" is not a supported runtime.  Supported runtimes are:

Instead of:
Runtime is not a supported runtime.  Supported runtimes are:

Which implies that "Runtime" is the name of the runtime you
tried to build, but in fact it was "".

Added: 
    

Modified: 
    llvm/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 60e1f29620af..253511415606 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -157,7 +157,7 @@ if(LLVM_ENABLE_RUNTIMES STREQUAL "all")
 endif()
 foreach(proj IN LISTS LLVM_ENABLE_RUNTIMES)
   if (NOT "${proj}" IN_LIST LLVM_SUPPORTED_RUNTIMES)
-    message(FATAL_ERROR "Runtime ${proj} is not a supported runtime. Supported runtimes are: ${LLVM_SUPPORTED_RUNTIMES}")
+    message(FATAL_ERROR "Runtime \"${proj}\" is not a supported runtime. Supported runtimes are: ${LLVM_SUPPORTED_RUNTIMES}")
   endif()
 endforeach()