[PATCH] D138443: [AMDGPU] Fix GCNSubtarget::getMinNumVGPRs, add unit test to check consistency between GCNSubtarget's getMinNumVGPRs, getMaxNumVGPRs and getOccupancyWithNumVGPRs.

Mon Dec 5 02:53:18 PST 2022

vpykhtin marked an inline comment as done.
vpykhtin added inline comments.

================
Comment at: llvm/unittests/Target/AMDGPU/CMakeLists.txt:6-9
 set(LLVM_LINK_COMPONENTS
   AMDGPUCodeGen
   AMDGPUDesc
   AMDGPUInfo
----------------
jmmartinez wrote:
> vpykhtin wrote:
> > jmmartinez wrote:
> > > I think `AMDGPUUtils` is missing from the list. Otherwise I get an undefined reference to `llvm::AMDGPU::IsaInfo::getMaxNumVGPRs(llvm::MCSubtargetInfo const*, unsigned int)` on my local build.
> > not sure, my build is ok, I build AMDGPUTests executable. Probably should go to another patch
> Are you building with `-DBUILD_SHARED_LIBS=OFF` ? If that's the case please consier reproducing the problem with `-DBUILD_SHARED_LIBS=ON` and adding the modification I suggested, to avoid breaking other peoples's builds.
Done, thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138443/new/

https://reviews.llvm.org/D138443