[PATCH] D137819: [XCOFF] support the overflow section (only relocation overflow is handled).

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'm okay with an NFC reformatting patch if it's needed, rather than trying to bundle together the changes in with functional changes.



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1084
+    // Find its corresponding overflow section.
+    for (auto &OvrfloSec : OverflowSections) {
+      if (OvrfloSec.RelocationCount == static_cast<uint32_t>(Sec->Index)) {
----------------
Noting another incident of `OvrflowSec`, which should be `OverflowSec`.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:834
+      // primary section header and s_nlnno must have the same value.
+      // For common section header, either of s_nreloc or s_nlnno is set to
+      // 65535, the other one must also be set to 65535.
----------------
jhenderson wrote:
> 
Ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819