[PATCH] D138475: [SCEVExpander] Support cost evaluation of several SCEVs with same budget

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/ScalarEvolutionExpander.h:226
+  bool isHighCostExpansion(ArrayRef<const SCEV *> Exprs, Loop *L,
+                           unsigned Budget, const TargetTransformInfo *TTI,
                            const Instruction *At) {
----------------
lebedev.ri wrote:
> I was thinking `Budget` should be a non-const-ref,
> and we should just subtract the computed cost from it
> if we return false from this function.
> Would that be worse?
I think it should be fine, let's try it out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138475/new/

https://reviews.llvm.org/D138475