[PATCH] D139210: [llvm-objcopy] Fix --section-add when section contain empty bytes

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 23:53:43 PST 2022


jhenderson added a comment.

Nit: the reiew title uses `--section-add` but the option is `--add-section`. Please update.



================
Comment at: llvm/test/tools/llvm-objcopy/wasm/add-section.test:23
 
+# Check that raw data bytes can be imported and exported unchanged especially the ones containing empty bytes.
+# RUN: echo -e -n "\x02\x01\x00\x01\x02" > %t6
----------------
Nit: most comments in tests in llvm-objcopy, including some in this file, use `##` to mark them rather than just `#` to distinguish them from lit test directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139210/new/

https://reviews.llvm.org/D139210



More information about the llvm-commits mailing list