[PATCH] D139295: [Coroutines] Don't mark the parameter attribute of resume function as noalias

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 23:03:08 PST 2022


ChuanqiXu created this revision.
ChuanqiXu added reviewers: rjmccall, nikic.
Herald added subscribers: jeroen.dobbelaere, hiraditya.
Herald added a project: All.
ChuanqiXu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Close https://github.com/llvm/llvm-project/issues/59221.

The root cause for the problem is that we marked the parameter of the resume/destroy functions as noalias previously. But this is not true. There are a lot of getelementptr uses for the parameter in the resume/destroy functions. This violates the assumption of `noalias`. So it would be better to remove this attribute.


https://reviews.llvm.org/D139295

Files:
  clang/test/CodeGenCoroutines/pr59221.cpp
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/test/Transforms/Coroutines/coro-debug-dbg.addr.ll
  llvm/test/Transforms/Coroutines/coro-debug-dbg.values-not_used_in_frame.ll
  llvm/test/Transforms/Coroutines/coro-debug-dbg.values.ll
  llvm/test/Transforms/Coroutines/coro-debug.ll
  llvm/test/Transforms/Coroutines/coro-frame.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139295.479987.patch
Type: text/x-patch
Size: 11465 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221205/54391451/attachment.bin>


More information about the llvm-commits mailing list