[PATCH] D107951: [ELF] Produce DT_RISCV_VARIANT_CC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 21:57:55 PST 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1426-1429
+      if (llvm::find_if(in.relaPlt->relocs, [](const DynamicReloc &r) {
+            return r.type == target->pltRel &&
+                   (r.sym->stOther & STO_RISCV_VARIANT_CC);
+          }) != in.relaPlt->relocs.end())
----------------
kito-cheng wrote:
> nit: Maybe `llvm::any_of`? although use `llvm::_find_if` can archive same purpose, but `any_of` might improve readable here?
Thanks for the suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107951/new/

https://reviews.llvm.org/D107951



More information about the llvm-commits mailing list