[PATCH] D139285: [LoongArch] Allow writing unaligned nop sequences

wanglei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 19:22:39 PST 2022


wangleiat added a comment.

In D139285#3969668 <https://reviews.llvm.org/D139285#3969668>, @xen0n wrote:

> LGTM.
>
> I've edited the title and summary for you, mainly for correcting one semantic mistake in the summary ("switches the bytes to not be dependent on endianness, even though we have only little endian" -- you most certainly didn't mean that, we //definitely// want the output to be valid little-endian LoongArch machine code, and the host's endianness shouldn't matter. The semantics could be inadvertently reversed by mistranslation).

Thank you very much!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139285/new/

https://reviews.llvm.org/D139285



More information about the llvm-commits mailing list