[PATCH] D139217: [CodeExtractor] Correctly propagate scope information post extraction
Felipe de Azevedo Piovezan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 4 14:11:48 PST 2022
fdeazeve added a comment.
>> Can you make an assertion that the Node is distinct? Otherwise this would be dangerous.
>
> The assert on line 73 is doing that (assert(!N.isUniqued())). This assert allo
Oops, I realized I never finish the sentence above! That assert (which is now in the `setScope` function), checks whether the node is either temporary or distinct, both conditions which would allow mutation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139217/new/
https://reviews.llvm.org/D139217
More information about the llvm-commits
mailing list