[PATCH] D138352: [RISCV] Support .variant_cc directive for the assembler.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 10:45:15 PST 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/RISCV/directive-variant_cc.s:39
+// ERR-NEXT:   .variant_cc
+// ERR-NEXT:              ^
+
----------------
Delete `// ERR-NEXT:   .variant_cc` and this line. The error mark is tested by other tests and this without --strict-whitespace --match-full-lines isn't useful.


================
Comment at: llvm/test/MC/RISCV/directive-variant_cc.s:45
+// ERR-NEXT:   .variant_cc fox bar
+// ERR-NEXT:                   ^
+.endif
----------------
Delete this line. The error mark is tested by other tests and this without --strict-whitespace --match-full-lines isn't useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138352/new/

https://reviews.llvm.org/D138352



More information about the llvm-commits mailing list