[PATCH] D136078: Use-after-return sanitizer binary metadata

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D136078#3969091 <https://reviews.llvm.org/D136078#3969091>, @melver wrote:

> In D136078#3969061 <https://reviews.llvm.org/D136078#3969061>, @MaskRay wrote:
>
>> ` SanitizerBinaryMetadata::createZeroSizedObjectInSection` creates `__dummy_*`, but why is it needed? (There is no comment.)
>
>
>
>   // Create a 0-sized object in a section, so that the section is not discarded
>   // if all inputs have been discarded.
>
> We need the `__begin` and `__end` markers even if there ends up being no binary metadata.

Thanks! I saw the comment associated with `createZeroSizedObjectInSection` but wasn't so sure if it was only for section based garbage collection.
If that's the case, D139276 <https://reviews.llvm.org/D139276> ExternalWeakLinkage would be a more size efficient fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136078/new/

https://reviews.llvm.org/D136078