[PATCH] D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types.

[Amy Kwan via Phabricator via llvm-commits]

amyk updated this revision to Diff 479927.
amyk added a comment.

Discussed this patch with Nemanja outside of the review.

Many of the cases where we get worse codegen on BE (and some on LE as well) within the test cases occur either when the shuffle mask is explicitly asking for undefined vector elements from the original `scalar_to_vector`, or when the values in the vector are partially defined in the cases where the `scalar_to_vector` element size is smaller than the `vector_shuffle` element size. These cases primarily seem to appear within these contrived test cases, rather than real code. As a result, I've rebased this patch and addressed some review comments to move forward with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130487/new/

https://reviews.llvm.org/D130487

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/p8-scalar_vector_conversions.ll
  llvm/test/CodeGen/PowerPC/v16i8_scalar_to_vector_shuffle.ll
  llvm/test/CodeGen/PowerPC/v2i64_scalar_to_vector_shuffle.ll
  llvm/test/CodeGen/PowerPC/v4i32_scalar_to_vector_shuffle.ll
  llvm/test/CodeGen/PowerPC/v8i16_scalar_to_vector_shuffle.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130487.479927.patch
Type: text/x-patch
Size: 138934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221204/ae5ff21f/attachment.bin>