[PATCH] D137819: [XCOFF] support the overflow section (only relocation overflow are handled).

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 4 07:54:42 PST 2022


Esme added a comment.

In D137819#3953495 <https://reviews.llvm.org/D137819#3953495>, @DiggerLin wrote:

> In D137819#3939790 <https://reviews.llvm.org/D137819#3939790>, @Esme wrote:
>
>> In D137819#3925955 <https://reviews.llvm.org/D137819#3925955>, @DiggerLin wrote:
>>
>>> change the description to 'support the relocation overflow section."
>>
>> As the doc says, the overflow section is required when either of the relocation entries or the line number entries exceeds 65,534. As long as one of the counts exceeds 65,534, the other one will also be set to 65535 in the primary section header, and then the overflow section will record actual counts for both relocation entries and line number entries, where the s_paddr for relocation entries and s_vaddr for line number entries.
>> Therefore I reckon there's no need to identify whether it's a relocation overflow section or line number overflow section.
>
>
>
>   if one day, you want to add the functionality patch of overflow section for line number , what title  you want to use for that new patch? 

Updated the title and description. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819



More information about the llvm-commits mailing list