[PATCH] D133760: [VPlan] Support sinking VPScalarIVStepsRecipe.
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 4 01:33:39 PST 2022
Ayal added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:52
case VPBranchOnMaskSC:
+ case VPScalarIVStepsSC:
return false;
----------------
nit: indicating that VPScalarIVStepsSC may not write or read from memory is independent of this patch but is exercised by it.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:141
+ if (SinkCandidate->getParent() == SinkTo)
+ continue;
----------------
nit: checking if SinkCandidate already resides in SinkTo is independent of its recipe type and can be combined with above `if (!SinkCandidate || ...)` checks, as suggested above?
================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:166
+ Instruction *I = cast<Instruction>(
+ cast<VPReplicateRecipe>(SinkCandidate)->getUnderlyingValue());
auto *Clone =
----------------
Still use (uncaptured) SinkCandidate in addition to SinkCandidateValue?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133760/new/
https://reviews.llvm.org/D133760
More information about the llvm-commits
mailing list