[PATCH] D139092: [RFC][LLD][ELF] Cortex-M Security Extensions (CMSE) Support

Sat Dec 3 16:58:23 PST 2022

MaskRay added a comment.

I am very familiar with lld/ELF. However, after rereading the description twice I was still quite puzzled until I started to read the implementation.
I think the description can use some reorganization. A random user will likely be more confused than I.

The 3 newly added options are critical for a reader, but the description is unclear.

- `The '--in-implib=file' specifies ...` has a vague description then stops describing more semantics.
- `ld emits a warning is given if no '--out-implib' is given but new symbols have` (typo?) The paragraph should just say what `--out-implib` does. `was needed in ld maybe because` can be moved to a footnote (`Reference`).
- `LLD does not implement '--out-implib' so the '--cmse-implib' option seems redundant at the moment.` I'm puzzled. Doesn't this patch add `--out-implib`
- `Make import library to be a secure gateway import` => grammar error in `to be`?
- Option `HelpText`: please don't just follow GNU ld which have very vague description. These options can use better description. If necessary, add more information to `lld/docs/ld.lld.1`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092