[PATCH] D139092: [RFC][LLD][ELF] Cortex-M Security Extensions (CMSE) Support

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: lld/ELF/Arch/ARM.cpp:934
+
+  inputSections.push_back(symTab);
+  inputSections.push_back(symTabShndx);
----------------
MaskRay wrote:
> amilendra wrote:
> > tschuett wrote:
> > > I have literally no idea what you are doing, but you create a `SmallVector` `inputSections` of size 0 and then immediately add 4 elements.
> > Thanks for pointing it out. I'll improve it.
> `SmallVector<SyntheticSection *, ４>` instantiates some code which bloats the lld executable. `SmallVector<SyntheticSection *, 0>` makes sense if `SmallVector<SyntheticSection *, ４>` hasn't been used globally.
Then it is binary size vs. malloc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092