[PATCH] D139238: [ARM] IselLowering unsigned overflow to crash using APInt in PerformSHLSimplify
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 3 03:15:43 PST 2022
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13777
+ uint64_t C2Value = C2Int.getZExtValue();
+ if (C2Width <= C2Value)
+ return SDValue();
----------------
I'm not sure if you can encounter types > 64 bits here - but you might be better doing the test as
```
if (C2Int.uge(C2Width))
return SDValue();
uint64_t C2Value = C2Int.getZExtValue();
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139238/new/
https://reviews.llvm.org/D139238
More information about the llvm-commits
mailing list