[PATCH] D139092: [RFC][LLD][ELF] Cortex-M Security Extensions (CMSE) Support
Amilendra Kodithuwakku via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 3 03:07:35 PST 2022
amilendra added inline comments.
================
Comment at: lld/ELF/Arch/ARM.cpp:934
+
+ inputSections.push_back(symTab);
+ inputSections.push_back(symTabShndx);
----------------
tschuett wrote:
> I have literally no idea what you are doing, but you create a `SmallVector` `inputSections` of size 0 and then immediately add 4 elements.
Thanks for pointing it out. I'll improve it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139092/new/
https://reviews.llvm.org/D139092
More information about the llvm-commits
mailing list