[llvm] 6272f87 - [AArch64] Make ArchInfo copyable again

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 3 03:00:09 PST 2022


Author: Benjamin Kramer
Date: 2022-12-03T11:49:16+01:00
New Revision: 6272f87ba06132a1b479068759d72178e5fe4472

URL: https://github.com/llvm/llvm-project/commit/6272f87ba06132a1b479068759d72178e5fe4472
DIFF: https://github.com/llvm/llvm-project/commit/6272f87ba06132a1b479068759d72178e5fe4472.diff

LOG: [AArch64] Make ArchInfo copyable again

I don't see the point of disallowing copying an aggregate, and C++20
makes aggregate initializing a class with a deleted copy ctor
ill-formed.

Added: 
    

Modified: 
    llvm/include/llvm/Support/AArch64TargetParser.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/AArch64TargetParser.h b/llvm/include/llvm/Support/AArch64TargetParser.h
index df560994a350..d7de0a47f760 100644
--- a/llvm/include/llvm/Support/AArch64TargetParser.h
+++ b/llvm/include/llvm/Support/AArch64TargetParser.h
@@ -114,12 +114,6 @@ struct ArchInfo {
   StringRef ArchFeature; // Command line feature flag, e.g. +v8a
   uint64_t DefaultExts;  // bitfield of default extensions ArchExtKind
 
-  // These are not intended to be copied or created outside of this file.
-  ArchInfo(const ArchInfo &) = delete;
-  ArchInfo(const ArchInfo &&) = delete;
-  ArchInfo &operator=(const ArchInfo &rhs) = delete;
-  ArchInfo &&operator=(const ArchInfo &&rhs) = delete;
-
   // Comparison is done by address. Copies should not exist.
   bool operator==(const ArchInfo &Other) const { return this == &Other; }
   bool operator!=(const ArchInfo &Other) const { return this != &Other; }


        


More information about the llvm-commits mailing list