[PATCH] D138352: [RISCV] Support .variant_cc directive for the assembler.
Yeting Kuo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 2 19:55:22 PST 2022
fakepaper56 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2312
+ StringRef SymbolName = Tok.getIdentifier();
+ MCSymbol *Sym = getContext().lookupSymbol(SymbolName);
+ if (!Sym)
----------------
MaskRay wrote:
> `MCSymbol *Sym = getContext().lookupSymbol(SymbolName);` is not the best. See D122507
Good point. Thank your reminder.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138352/new/
https://reviews.llvm.org/D138352
More information about the llvm-commits
mailing list