[PATCH] D139210: [llvm-objcopy] Fix --section-add when section contain empty bytes

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 16:04:17 PST 2022


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/add-section.test:23
 
+# Check that raw data can be imported and exported unchanged.
+# RUN: echo -en '\x02\x01\x00\x01\x02' > %t6
----------------
nit: Can you mention in the comment that zero bytes are an important component of this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139210/new/

https://reviews.llvm.org/D139210



More information about the llvm-commits mailing list