[PATCH] D110776: A new hidden option exec-on-ir-change=exe that calls exe after each time IR changes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

one coding comment



================
Comment at: llvm/lib/IR/PrintPasses.cpp:158
 
-std::string llvm::doSystemDiff(StringRef Before, StringRef After,
-                               StringRef OldLineFormat, StringRef NewLineFormat,
-                               StringRef UnchangedLineFormat) {
-  StringRef SR[2]{Before, After};
-  // Store the 2 bodies into temporary files and call diff on them
-  // to get the body of the node.
-  const unsigned NumFiles = 3;
-  static std::string FileName[NumFiles];
-  static int FD[NumFiles]{-1, -1, -1};
-  for (unsigned I = 0; I < NumFiles; ++I) {
+Optional<std::string>
+llvm::prepareTempFiles(SmallVector<int> &FD, ArrayRef<StringRef> SR,
----------------
this (and below) should use `ErrorOr`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110776/new/

https://reviews.llvm.org/D110776