[PATCH] D138995: [CodeView] Add support for local S_CONSTANT records

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 13:47:03 PST 2022


aganea accepted this revision.
aganea added a subscriber: akhuang.
aganea added a comment.
This revision is now accepted and ready to land.

LGTM, but wait until next week before landing, in case others would like to comment. + @akhuang



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1346
     if (!Location)
+    {
+      // When we don't have a location this is usually because LLVM has
----------------
Bracket on wrong line, please apply `git clang-format`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138995/new/

https://reviews.llvm.org/D138995



More information about the llvm-commits mailing list