[PATCH] D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations.

Fri Dec 2 13:46:16 PST 2022

DiggerLin added inline comments.

================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:648
+    // instr address plus any constant value.
+    FixedValue =
+        SectionMap[SymASec]->Address - BRInstrAddress + Target.getConstant();
----------------
DiggerLin wrote:
> according to 
> https://www.ibm.com/docs/en/aix/7.2?topic=formats-xcoff-object-file-format#XCOFF__sua3i125jbau
> 
> R_RBR
> Specifies (relative) branch relocation. Provides //a displacement value between the address of the symbol specified by the r_symndx field and the address of the csect containing the branch instruction to be modified.// The instruction can be modified to an absolute branch instruction if the target address is not relocatable.
but the output looks correct.  the document is error? or I misunderstand the doc ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138982/new/

https://reviews.llvm.org/D138982