[PATCH] D139215: [ORC][test] Add initial MachOPlatformTest

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 13:42:26 PST 2022


keith added a comment.

2 thoughts:

1. having any tests for this class might be nice for encouraging others to add tests when they change this type, since this would already be setup
2. there are other callers to this function so regardless of what ORC keeps doing, this makes sure this functionality continues to work as expected for the other callers

but yea I don't feel strongly, so i can drop if you think that's the right move


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139215/new/

https://reviews.llvm.org/D139215



More information about the llvm-commits mailing list