[PATCH] D138952: Support: Add polling option to sys::Wait [WIP]

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 13:39:24 PST 2022


aganea added inline comments.


================
Comment at: llvm/lib/Support/Unix/Program.inc:429
       if (SecondsToWait && errno == EINTR) {
+        if (Polling)
+          return WaitResult;
----------------
I wouldn't return right away, `ProcStat` is not yet updated at this point. I think enclosing all this into `if (!Polling)` like before would be fine. Seems good otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138952/new/

https://reviews.llvm.org/D138952



More information about the llvm-commits mailing list