[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added a comment.

In order to stage this, I changed this to emit the old version. I will need to submit another patch once the llvm is integrated into our create_llvm_prof tooling.



================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:263-266
+  if (&MF.front() != EntryBlock) {
+    report_fatal_error(
+        "Entry block should not be displaced by basic block sections");
+  }
----------------
jhenderson wrote:
> Why `report_fatal_error` here? If this case can be hit by proper user code, should the error by propagated up to the call site? If not, why not an assertion?
This is a hard failure and is not expected to happen. I changed to `report_fatal_error` to suppress the unused variable warning, but now I know I can used `[[maybe_unused]]` to do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100808/new/

https://reviews.llvm.org/D100808