[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman resigned from this revision.
aaron.ballman added a comment.

I don't know enough about lld to be an appropriate reviewer for this, but the PE bits look correct based on my (limited) understanding of PE.



================
Comment at: lld/COFF/Writer.cpp:621
+                         uint32_t WordCount) -> uint16_t {
+    uint16_t *p = (uint16_t *)BaseAddress;
+    uint32_t sum = StartValue;
----------------
Something to double-check: is `BaseAddress` going to be aligned properly for dereferencing `p`? I believe this is fine, but it's worth verifying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184