[PATCH] D139213: [llvm][CUDA] Make NVVM Reflect pass look inside ptr casting

Hugh Delaney via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 11:32:05 PST 2022


hdelan updated this revision to Diff 479696.
hdelan added a comment.

- Adding test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139213/new/

https://reviews.llvm.org/D139213

Files:
  llvm/include/llvm/IR/InstrTypes.h
  llvm/lib/Target/NVPTX/NVVMReflect.cpp
  llvm/test/CodeGen/NVPTX/nvvm-reflect-cast.ll


Index: llvm/test/CodeGen/NVPTX/nvvm-reflect-cast.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/NVPTX/nvvm-reflect-cast.ll
@@ -0,0 +1,21 @@
+; Verify that __nvvm_reflect() is replaced with an appropriate value when
+; wrapped in bitcast.
+;
+; RUN: opt %s -S -passes='default<O2>' -mtriple=nvptx64 \
+; RUN:   | FileCheck %s --check-prefixes=COMMON,SM20
+; RUN: opt %s -S -passes='default<O2>' -mtriple=nvptx64 -mcpu=sm_35 \
+; RUN:   | FileCheck %s --check-prefixes=COMMON,SM35
+
+@"$str" = private addrspace(4) constant [12 x i8] c"__CUDA_ARCH\00"
+
+declare i32 @__nvvm_reflect(i8*)
+
+; COMMON-LABEL: @foo
+define i32 @foo(float %a, float %b) {
+; COMMON-NOT: call i32 @__nvvm_reflect
+  %reflect = tail call i32 bitcast (i32 (i8*)* @__nvvm_reflect to i32 (i8 addrspace(4)*)*)(i8 addrspace(4)* noundef getelementptr inbounds ([12 x i8], [12 x i8] addrspace(4)* @"$str", i64 0, i64 0))
+; SM20: ret i32 200  
+; SM35: ret i32 350  
+  ret i32 %reflect
+}
+
Index: llvm/lib/Target/NVPTX/NVVMReflect.cpp
===================================================================
--- llvm/lib/Target/NVPTX/NVVMReflect.cpp
+++ llvm/lib/Target/NVPTX/NVVMReflect.cpp
@@ -118,6 +118,8 @@
     if (!Call)
       continue;
     Function *Callee = Call->getCalledFunction();
+    if (!Callee)
+      Callee = Call->getCalledFunctionRemovingPtrCasts();
     if (!Callee || (Callee->getName() != NVVM_REFLECT_FUNCTION &&
                     Callee->getIntrinsicID() != Intrinsic::nvvm_reflect))
       continue;
Index: llvm/include/llvm/IR/InstrTypes.h
===================================================================
--- llvm/include/llvm/IR/InstrTypes.h
+++ llvm/include/llvm/IR/InstrTypes.h
@@ -1401,6 +1401,13 @@
     return nullptr;
   }
 
+  /// Returns the function called and removes the pointer casting around it
+  Function *getCalledFunctionRemovingPtrCasts() const {
+    if (auto *Operand = getCalledOperand())
+      return dyn_cast_or_null<Function>(Operand->stripPointerCasts());
+    return nullptr;
+  }
+
   /// Return true if the callsite is an indirect call.
   bool isIndirectCall() const;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139213.479696.patch
Type: text/x-patch
Size: 2162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221202/7cdd7bfc/attachment.bin>


More information about the llvm-commits mailing list